feat(pt): consistent "frozen" model#3450
Merged
wanghan-iapcm merged 7 commits intodeepmodeling:develfrom Mar 12, 2024
Merged
Conversation
After deepmodeling#3438, `model_def_script` is no more saved in AtomicModel. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3450 +/- ##
==========================================
+ Coverage 77.29% 77.34% +0.04%
==========================================
Files 427 428 +1
Lines 36910 37005 +95
Branches 1621 1621
==========================================
+ Hits 28529 28620 +91
- Misses 7513 7517 +4
Partials 868 868 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
approved these changes
Mar 12, 2024
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for model_file in (pt_model, tf_model): | ||
| try: | ||
| os.remove(model_file) | ||
| except FileNotFoundError: |
Check notice
Code scanning / CodeQL
Empty except
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #3449, as the test needs #3449 to pass.
Add a consistent
frozenmodel in pt. Both TF and PT now support using models in any format.