Clean TODOs and convert them into issues#3519
Merged
wanghan-iapcm merged 6 commits intodeepmodeling:develfrom Mar 19, 2024
Merged
Clean TODOs and convert them into issues#3519wanghan-iapcm merged 6 commits intodeepmodeling:develfrom
wanghan-iapcm merged 6 commits intodeepmodeling:develfrom
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3519 +/- ##
==========================================
- Coverage 77.48% 77.47% -0.02%
==========================================
Files 432 432
Lines 37151 37164 +13
Branches 1620 1620
==========================================
+ Hits 28786 28791 +5
- Misses 7497 7505 +8
Partials 868 868 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| descriptor_shape.AddDim(em_tensor.shape().dim_size(0)); | ||
| descriptor_shape.AddDim( | ||
| em_tensor.shape().dim_size(1)); // TODO: be careful here; | ||
| descriptor_shape.AddDim(em_tensor.shape().dim_size(1)); // be careful here; |
Check notice
Code scanning / CodeQL
Commented-out code
| TensorShape descriptor_shape; | ||
| descriptor_shape.AddDim(em_tensor.shape().dim_size(0)); | ||
| descriptor_shape.AddDim(4); // TODO: be careful here; | ||
| descriptor_shape.AddDim(4); // be careful here; |
Check notice
Code scanning / CodeQL
Commented-out code
| TensorShape descriptor_shape; | ||
| descriptor_shape.AddDim(em_tensor.shape().dim_size(0)); | ||
| descriptor_shape.AddDim(4); // TODO: be careful here; | ||
| descriptor_shape.AddDim(4); // be careful here; |
Check notice
Code scanning / CodeQL
Commented-out code
wanghan-iapcm
approved these changes
Mar 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About 50+ issues will be created after this PR is merged.