compute output stat for atomic model#3642
Merged
wanghan-iapcm merged 13 commits intodeepmodeling:develfrom Apr 7, 2024
Merged
Conversation
added 4 commits
April 4, 2024 01:43
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def setUp(self): | ||
| TestCaseSingleFrameWithNlist.setUp(self) | ||
| nf, nloc, nnei = self.nlist.shape |
Check notice
Code scanning / CodeQL
Unused local variable
|
|
||
| def setUp(self): | ||
| TestCaseSingleFrameWithNlist.setUp(self) | ||
| nf, nloc, nnei = self.nlist.shape |
Check notice
Code scanning / CodeQL
Unused local variable
|
|
||
| def setUp(self): | ||
| TestCaseSingleFrameWithNlist.setUp(self) | ||
| nf, nloc, nnei = self.nlist.shape |
Check notice
Code scanning / CodeQL
Unused local variable
| pair_exclude_types: List[Tuple[int, int]] = [], | ||
| ): | ||
| super().__init__() | ||
| self.type_map = type_map |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3642 +/- ##
==========================================
+ Coverage 81.72% 81.80% +0.07%
==========================================
Files 503 503
Lines 46007 46445 +438
Branches 2891 2952 +61
==========================================
+ Hits 37601 37993 +392
- Misses 7528 7559 +31
- Partials 878 893 +15 ☔ View full report in Codecov by Sentry. |
njzjz
approved these changes
Apr 4, 2024
anyangml
approved these changes
Apr 6, 2024
iProzd
requested changes
Apr 6, 2024
Co-authored-by: Duo <50307526+iProzd@users.noreply.github.com> Signed-off-by: Han Wang <92130845+wanghan-iapcm@users.noreply.github.com>
for more information, see https://pre-commit.ci
iProzd
approved these changes
Apr 6, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
njzjz
reviewed
Jul 10, 2024
| atom_exclude_types: List[int] = [], | ||
| pair_exclude_types: List[Tuple[int, int]] = [], | ||
| rcond: Optional[float] = None, | ||
| preset_out_bias: Optional[Dict[str, torch.Tensor]] = None, |
Member
There was a problem hiding this comment.
line 74 is different from line 60
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
compute_or_load_output_statfor the base atomic model. the method computes both bias and std.compute_or_load_output_statmethod for computing output stat.apply_out_stat, the derived class may override the method to define how the statistics is applied to an atomic model's output. @anyangml may need.out_statsupport statistics of output tensor of any shape.@iProzd please check if i took it correctly in ce7ec1f
To be done: