Skip to content

chore: remove type embedding TODO from se_r serialize #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anyangml merged 1 commit into from
Jun 2, 2024
Merged

chore: remove type embedding TODO from se_r serialize #3845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions deepmd/tf/descriptor/se_r.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,9 +765,6 @@ def serialize(self, suffix: str = "") -> dict:
raise NotImplementedError("spin is unsupported")
assert self.davg is not None
assert self.dstd is not None
# TODO: tf: handle type embedding in DescrptSeR.serialize
# not sure how to handle type embedding - type embedding is not a model parameter,
# but instead a part of the input data. Maybe the interface should be refactored...
return {
"@class": "Descriptor",
"type": "se_r",
Expand Down