Skip to content

fix(tf): prevent fitting_attr variable scope from becoming fitting_attr_1 #3930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iProzd merged 5 commits into from
Jul 2, 2024
Merged

fix(tf): prevent fitting_attr variable scope from becoming fitting_attr_1 #3930

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39bd6be
fix(pt): change fitting_attr variable scope reuse to AUTO_REUSE
njzjz Jun 29, 2024
b82d434
Revert "fix(pt): change fitting_attr variable scope reuse to AUTO_REUSE"
njzjz Jun 29, 2024
2ccaa22
fix according to https://stackoverflow.com/a/40884220/9567349
njzjz Jun 29, 2024
5ac42c3
Revert "fix according to https://stackoverflow.com/a/40884220/9567349"
njzjz Jun 29, 2024
70d4d4e
avoid using namespace
njzjz Jun 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions deepmd/tf/descriptor/se_a_mask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,9 @@ def build(
aparam[:, :] is the real/virtual sign for each atom.
"""
aparam = input_dict["aparam"]
with tf.variable_scope("fitting_attr" + suffix, reuse=reuse):
t_aparam_nall = tf.constant(True, name="aparam_nall", dtype=tf.bool)
t_aparam_nall = tf.constant(

Check notice

Code scanning / CodeQL

Unused local variable

Variable t_aparam_nall is not used.
True, name=f"fitting_attr{suffix}/aparam_nall", dtype=tf.bool
)
Comment thread
njzjz marked this conversation as resolved.
self.mask = tf.cast(aparam, tf.int32)
self.mask = tf.reshape(self.mask, [-1, natoms[1]])

Expand Down