fix(pt): ensure suffix of --init_model and --restart is .pt#3980
Merged
njzjz merged 1 commit intodeepmodeling:develfrom Jul 16, 2024
Merged
fix(pt): ensure suffix of --init_model and --restart is .pt#3980njzjz merged 1 commit intodeepmodeling:develfrom
--init_model and --restart is .pt#3980njzjz merged 1 commit intodeepmodeling:develfrom
Conversation
... as in the command line help, we say "path prefix of checkpoint files". This will be compatible with the current DP-GEN code. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Contributor
WalkthroughWalkthroughThe change in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3980 +/- ##
==========================================
- Coverage 82.83% 82.82% -0.02%
==========================================
Files 522 522
Lines 50872 50876 +4
Branches 3015 3015
==========================================
- Hits 42142 42140 -2
- Misses 7795 7799 +4
- Partials 935 937 +2 ☔ View full report in Codecov by Sentry. |
Member
Author
|
RTD error submitted to sphinx-doc/sphinx-argparse#56 |
wanghan-iapcm
approved these changes
Jul 16, 2024
iProzd
approved these changes
Jul 16, 2024
mtaillefumier
pushed a commit
to mtaillefumier/deepmd-kit
that referenced
this pull request
Sep 18, 2024
…epmodeling#3980) ... as in the command line help, we say "path prefix of checkpoint files". This will be compatible with the current DP-GEN code. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Ensured that the `.pt` suffix is automatically appended to `init_model` and `restart` file paths if not already present. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as in the command line help, we say "path prefix of checkpoint files". This will be compatible with the current DP-GEN code.
Summary by CodeRabbit
.ptsuffix is automatically appended toinit_modelandrestartfile paths if not already present.