fix: fix nopbc in dpdata driver

[njzjz]

Sometimes dpdata data may contain "nopbc": False (from ase or n2p2).

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of the "nopbc" key in the data processing logic, enhancing the accuracy of cell variable assignments.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes in the driver.py file enhance the logic of the label method by modifying how the "nopbc" key is evaluated. The condition now uses the get method instead of a simple membership check, allowing for more robust handling of scenarios where "nopbc" may be present but set to False. This adjustment broadens the interpretation of the flag, ensuring better functionality and reliability.

Changes

File	Change Summary
deepmd/driver.py	Modified the conditional logic in the label method to use get for evaluating "nopbc", enhancing robustness.

Sequence Diagram(s)

sequenceDiagram
    participant A as User
    participant B as driver.py
    participant C as Data Dictionary

    A->>B: Call label method
    B->>C: Check for "nopbc" key
    alt "nopbc" is absent or False
        B->>B: Assign cell variable
    else "nopbc" is True
        B->>B: Proceed with alternative logic
    end
    B->>A: Return result

Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.93%. Comparing base (7f61048) to head (db052f0).
Report is 106 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #4027      +/-   ##
==========================================
- Coverage   82.93%   82.93%   -0.01%     
==========================================
  Files         522      522              
  Lines       51036    51036              
  Branches     3030     3028       -2     
==========================================
- Hits        42326    42325       -1     
+ Misses       7764     7763       -1     
- Partials      946      948       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.