Skip to content

feat(tf/pt): add/refact lammps support for spin model#4216

Closed
iProzd wants to merge 59 commits intodeepmodeling:develfrom
iProzd:spin_lmp
Closed

feat(tf/pt): add/refact lammps support for spin model#4216
iProzd wants to merge 59 commits intodeepmodeling:develfrom
iProzd:spin_lmp

Conversation

@iProzd
Copy link
Copy Markdown
Member

@iProzd iProzd commented Oct 15, 2024

Summary by CodeRabbit

  • New Features

    • Introduced spin handling capabilities in various models, enhancing energy and force computations.
    • Added support for new parameters in compute methods to accommodate ghost atoms and neighbor lists.
    • Implemented new classes and methods for managing spin interactions, including DeepSpin, DeepSpinModelDevi, and their TensorFlow and PyTorch counterparts.
    • Added a new pair style for LAMMPS simulations: PairDeepSpin.
    • Enhanced the DeepPot framework with spin support, including new API structures and functions.
    • Introduced a new function for writing LAMMPS data that includes spin information.
    • Added comprehensive functionality for error handling and tensor management in DeepSpinPT and DeepSpinTF.
    • Established a new testing framework for the DeepSpin class to validate its methods under various configurations.
  • Bug Fixes

    • Improved error handling in TensorFlow and PyTorch integrations to ensure robustness during model execution.
  • Tests

    • Established comprehensive unit tests for the DeepSpin class, validating spin-related computations and ensuring accuracy in energy and force calculations.
    • Introduced additional tests for the DeepSpin class, focusing on the compute method and verifying outputs against expected values.
    • Added unit tests for the DeepSpinPT class to validate its functionality.
    • Enhanced testing framework for LAMMPS spin simulations, ensuring correctness across various scenarios.
    • Developed tests for the DeepSpin class to validate its behavior with and without periodic boundary conditions.
  • Documentation

    • Enhanced documentation for new methods and classes to clarify usage and functionality related to spin interactions.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Support C++ interface for pytorch spin model.

5 participants