remove -std=c++17 for cuda<=10#759
Merged
amcadmus merged 1 commit intodeepmodeling:develfrom Jun 17, 2021
Merged
Conversation
cuda<=10 doesn't support `-std=c++17`, but conda compilers will add it into the flag. We can friendly remove such flag to prevent users go here and ask deepmodeling#428. fix deepmodeling#755.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #759 +/- ##
==========================================
+ Coverage 74.21% 74.23% +0.01%
==========================================
Files 82 76 -6
Lines 6520 6505 -15
==========================================
- Hits 4839 4829 -10
+ Misses 1681 1676 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 1, 2021
cuda<=10 doesn't support `-std=c++17`, but conda compilers will add it into the flag. We can friendly remove such flag to prevent users go here and ask deepmodeling#428. fix deepmodeling#755.
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Sep 21, 2023
* add auto cli docs * fix typo * fix package name... * forgot to return parser * add the blank line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cuda<=10 doesn't support
-std=c++17, but conda compilers will addit into the flag. We can friendly remove such flag to prevent users
go here and ask #428.
fix #755.