give a default value to T and convert models from v1.2#789
give a default value to T and convert models from v1.2#789amcadmus merged 4 commits intodeepmodeling:develfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #789 +/- ##
==========================================
- Coverage 74.05% 73.65% -0.41%
==========================================
Files 84 84
Lines 6576 6619 +43
==========================================
+ Hits 4870 4875 +5
- Misses 1706 1744 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
How about adding a section in the getting started to introduce the users the conversions of model compatibility? |
(and compatability->compatibility)
|
I add a table to troublesome and I am not sure if it should be moved to the getting started. |
tuoping
left a comment
tuoping
left a comment
There was a problem hiding this comment.
How about add a link to doc/troubleshooting/model-compatibility in getting-started?
| |DeePMD-kit v1.0 | 😢 | 😄 | 😢 | 😢 | 😢 | 😢 | | ||
| |DeePMD-kit v1.1 | 😢 | 😢 | 😄 | 😢 | 😢 | 😢 | | ||
| |DeePMD-kit v1.2 | 😢 | 😢 | 😢 | 😄 | 😢 | 😢 | | ||
| |DeePMD-kit v1.3 | 😢 | 😢 | 😢 | 😊 | 😄 | 😢 | |
There was a problem hiding this comment.
Do we have tools in DeePMD-kit v1.3 to convert v1.3 model to v1.2 compatibility?
There was a problem hiding this comment.
So why there is a smile? Is it a typo?
There was a problem hiding this comment.
The smile is where model version is v1.2 and deepmd-kit version is 1.3, not converse.
There was a problem hiding this comment.
So you mean we can convert a model v1.2 to v1.3 by using deepmd-kit v1.3. I do not see this subcommand in v1.3
There was a problem hiding this comment.
We can convert a model v1.2 to v1.3 by using deepmd-kit v1.2. So this should be a 😢?
There was a problem hiding this comment.
denghuilu
left a comment
denghuilu
left a comment
There was a problem hiding this comment.
works well in my local workstation
njzjz
force-pushed
the
v1.2-compatibility
branch
from
6d9de9b to
74c8d92
Compare
) * give a default value to T and convert models from v1.2 See also https://www.tensorflow.org/guide/create_op#backwards_compatibility. * add documents to model compatibility (and compatability->compatibility) * add documentation to getting-started * Update model-compatability.md
5 participants
See also https://www.tensorflow.org/guide/create_op#backwards_compatibility.
Implement #546.