Fix the expanding logic of SLURM_JOB_NODELIST and add unit tests for parallel training.#913
Merged
amcadmus merged 2 commits intodeepmodeling:develfrom Aug 2, 2021
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #913 +/- ##
==========================================
+ Coverage 74.68% 75.16% +0.47%
==========================================
Files 85 85
Lines 6748 6725 -23
==========================================
+ Hits 5040 5055 +15
+ Misses 1708 1670 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
61 tasks
shishaochen
changed the title
cluster and env.SLURM_JOB_NODELIST and add unit tests for parallel training.
amcadmus
approved these changes
Aug 2, 2021
njzjz
approved these changes
Aug 2, 2021
gzq942560379
pushed a commit
to HPC-AI-Team/deepmd-kit
that referenced
this pull request
Sep 2, 2021
…r parallel training. (deepmodeling#913) * Add unit tests of `cluster` and `env`. * Fix the expanding logic of `SLURM_JOB_NODELIST`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better code coverage and feature compatibility, add unit tests for #892 and #905.
Need to mention, the expanding logic of environment variable
SLURM_JOB_NODELISTis fixed with a professional package python-hostlist.