Fix DeepEP cannot be used together with code that needs GIL such as Mooncake transfer engine#142
Merged
LyricZhao merged 2 commits intodeepseek-ai:mainfrom May 8, 2025
Merged
Conversation
Contributor
|
in sglang code: If it is asynchronous mode, it is reasonable to say that this function should not hold CIL for a long time. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using DeepEP with Mooncake transfer engine, DeepEP's dispatch will hold the GIL for a long time, and thus other libraries such as Mooncake transfer engine, which uses Python code in another thread, cannot obtain the GIL and thus get stuck. Therefore, in this PR, I make DeepEP release GIL to fix this.