Merged
Conversation
Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
Collaborator
|
Interesting, thanks for finding this, Tunji, so then we don't need the condition at: DeepSpeed/deepspeed/runtime/zero/stage_1_and_2.py Line 1084 in 6b9cab1 as your added check will prevent it from ever being False at l1084 |
Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
stas00
reviewed
Feb 3, 2026
Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
stas00
approved these changes
Feb 3, 2026
Collaborator
stas00
left a comment
stas00
left a comment
There was a problem hiding this comment.
That fixes the issue, thank you, Tunji!
ksugama
pushed a commit
to ksugama/DeepSpeed
that referenced
this pull request
Feb 9, 2026
Correctly handle `ds_grad_is_ready` in ZeRO2 --------- Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Signed-off-by: Kento Sugama <kentosugama@protonmail.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly handle
ds_grad_is_readyin ZeRO2