This repository was archived by the owner on May 6, 2020. It is now read-only.
[WIP] ref(controller): tons of breaking changes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2015 10:52
List of changes are as follows: - removed legacy web UI - added ADMIN_ENABLED flag for /admin endpoint - replaced confd with kubernetes service discovery (PoC) - removed LDAP auth (for now) - removed etcd data migrations (v2 = code cleanup) - docker client now reads DOCKER_URL via service discovery - refactored rootfs to reflect final filesystem layout TODO: - remove database schema migrations, start from clean slate - fix up scheduler tests to use scheduler.mock - add back LDAP auth if user opts in - fix tests - m0ar cleanup Main motivation for removing confd entirely is so that the controller can take over PID 1 after we're done all the database migrations. That way we don't require all that `trap` logic. However that means we won't have a way to configure LDAP auth on the fly, which may or may not be important.
bacongobbler
force-pushed
the
refactor-confd-controller
branch
from
800bc2d to
8635200
Compare
Member
Author
|
closing as it's grown way too big for any person to reasonably review. Even I'm having a hard time reviewing my own changes! I'll break this up into smaller pieces. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes are as follows:
TODO:
Main motivation for removing confd entirely is so that the controller can take over PID 1 after we're done all the database migrations. That way we don't require all that
traplogic. However that means we won't have a way to configure LDAP auth on the fly, which may or may not be important.rebased on top of #2