Apply TemplateDotNetTool PR #76 - Replace role-based agents with standards-based model

[Copilot]

Pull Request

Description

Ports TemplateDotNetTool#76 into SonarMark, replacing the 5 monolithic role-based agents with a leaner standards-delegation model and adding structured standards references.

Agent restructure (.github/agents/)

• Removed 5 old agents: code-quality, requirements, software-developer, technical-writer, test-developer
• Added 3 new agents: developer (general-purpose, standards-based), implementation (RESEARCH→DEVELOPMENT→QUALITY→REPORT state machine), quality (compliance checklist grader)
• Updated code-review and repo-consistency with structured workflow and .agent-logs/-based reporting

New .github/standards/ directory

6 reusable standards files agents load on demand: csharp-language.md, csharp-testing.md, reqstream-usage.md, reviewmark-usage.md, software-items.md, technical-documentation.md

AGENTS.md

Rewritten around the standards-delegation model; agent report convention moved from AGENT_REPORT_*.md to .agent-logs/[agent]-[subject]-[id].md

Tooling/config

File	Change
lint.sh / lint.bat	npm install --silent, pip install --quiet --disable-pip-version-check, cspell --quiet
.markdownlint-cli2.yaml	Added noBanner: true, noProgress: true
.cspell.yaml, .gitignore, .yamllint.yaml	Exclude .agent-logs/
build.yaml	Removed --definition .reviewmark.yaml (auto-discovered by ReviewMark)

User guide folder renamed to match DEMA Consulting standards

• Renamed docs/guide/ → docs/user_guide/ to conform to the technical-documentation.md standard
• Renamed guide.md → introduction.md (file already opened with # Introduction as its first heading)
• Updated definition.yaml, build.yaml (Pandoc and Weasyprint steps), and README.md to reference the new paths

No functional code changes — agent/configuration/documentation files only.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

• Code builds successfully: dotnet build --configuration Release
• All unit tests pass: dotnet test --configuration Release
• Self-validation tests pass:
  dotnet run --project src/DemaConsulting.SonarMark --configuration Release --framework net10.0
--no-build -- --validate
• Code produces zero warnings

Code Quality

• Code formatting is correct: dotnet format --verify-no-changes
• New code has appropriate XML documentation comments
• Static analyzer warnings have been addressed

Linting

• All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

• Added unit tests for new functionality
• Updated existing tests if behavior changed
• All tests follow the AAA (Arrange, Act, Assert) pattern
• Test coverage is maintained or improved

Documentation

• Updated README.md (if applicable)
• Updated ARCHITECTURE.md (if applicable)
• Added code examples for new features (if applicable)
• Updated requirements.yaml (if applicable)

Additional Notes

Agent/config/documentation-only changes. No production code touched.

---

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

[Copilot]

Pull request overview

Aligns SonarMark with TemplateDotNetTool’s updated “standards-based agents” model by introducing shared standards docs, refreshing agent definitions, and tightening lint/config noise and exclusions to support agent-generated reports.

Changes:

• Replace old role-based agents with standards-based agents and update agent guidance in AGENTS.md.
• Add .github/standards/ documents to centralize development, testing, requirements, review, and documentation standards.
• Quiet lint tool output and exclude .agent-logs/ from linters and git ignore; simplify ReviewMark invocation in CI.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
lint.sh	Use quieter npm/pip/cspell flags to reduce lint output noise.
lint.bat	Windows equivalent quiet flags for npm/pip/cspell.
AGENTS.md	Update agent delegation model and quality gate checklist; add .agent-logs/ reporting guidance.
.yamllint.yaml	Ignore .agent-logs/ during YAML linting.
.markdownlint-cli2.yaml	Suppress banner/progress; ignore .agent-logs/; clarify MD024 comment.
.gitignore	Ignore .agent-logs/ directory.
.cspell.yaml	Ignore .agent-logs/ during spell checking.
.github/workflows/build.yaml	Remove explicit ReviewMark --definition .reviewmark.yaml argument.
.github/standards/csharp-language.md	Add C# coding standards (literate style, XML docs, DI, error handling).
.github/standards/csharp-testing.md	Add MSTest testing standards (AAA, naming, antipatterns).
.github/standards/reqstream-usage.md	Add ReqStream requirements management standards and command guidance.
.github/standards/reviewmark-usage.md	Add ReviewMark file review standards, examples, and command guidance.
.github/standards/software-items.md	Add software item categorization standards (system/subsystem/unit/OTS).
.github/standards/technical-documentation.md	Add technical documentation standards and Pandoc structure guidance.
.github/agents/code-review.agent.md	Update code-review agent workflow/reporting instructions.
.github/agents/repo-consistency.agent.md	Expand repo-consistency workflow steps and reporting template.
.github/agents/developer.agent.md	Add general-purpose developer agent aligned to standards.
.github/agents/implementation.agent.md	Add orchestrator agent with state-machine workflow.
.github/agents/quality.agent.md	Add quality assessment agent and report template.
.github/agents/requirements.agent.md	Remove old requirements agent definition.
.github/agents/software-developer.agent.md	Remove old software-developer agent definition.
.github/agents/test-developer.agent.md	Remove old test-developer agent definition.
.github/agents/technical-writer.agent.md	Remove old technical-writer agent definition.
.github/agents/code-quality.agent.md	Remove old code-quality agent definition.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Malcolmnixon]

@copilot apply changes based on the comments in this thread