Skip to content

Conversation

@mohlcyber
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

CP Threat Emulation provides a lower case combinedverdict like "benign". Previous code always set DBot Score to malicious also when it CP Threat Emulation returned a benign verdict. Code change fixes the DBot Score. Code Fix line 849.

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

As described in API documentation Threat Emulation provides a lower case benign.
Code Fix line 849
@CLAassistant
Copy link

CLAassistant commented Feb 7, 2023

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Feb 7, 2023
@content-bot content-bot changed the base branch from master to contrib/mohlcyber_master February 7, 2023 09:15
@content-bot content-bot requested a review from adi88d February 7, 2023 09:15
@content-bot
Copy link
Contributor

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @adi88d will know he can start review the proposed changes.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Feb 7, 2023
@mohlcyber mohlcyber changed the title Fix get_dbotscore() CheckPoint Threat Emulation / Sandblast - Fix get_dbotscore() Feb 9, 2023
@mohlcyber mohlcyber requested a review from daryakoval as a code owner February 9, 2023 11:56
Copy link
Contributor

@adi88d adi88d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mohlcyber ,
Thank you for your contribution!
Good work :)

Please bump the version of the pack in the pack_metadata.json file and add notes describing your changes to a new Release Notes file.
To do that, please run the demisto-sdk update-release-notes command - for more information please see: https://xsoar.pan.dev/docs/concepts/demisto-sdk#update-release-notes.

@mohlcyber
Copy link
Contributor Author

Hi @adi88d,
thanks for the prompt response. I did the required changes. Hope that works out.
All the best,
Martin

@mohlcyber mohlcyber requested review from adi88d and removed request for daryakoval February 10, 2023 16:16
@adi88d adi88d merged commit b24d876 into demisto:contrib/mohlcyber_master Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants