-
Notifications
You must be signed in to change notification settings - Fork 1.9k
CheckPoint Threat Emulation / Sandblast - Fix get_dbotscore() #24409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As described in API documentation Threat Emulation provides a lower case benign. Code Fix line 849
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @adi88d will know he can start review the proposed changes. |
latest content pull
adi88d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mohlcyber ,
Thank you for your contribution!
Good work :)
Please bump the version of the pack in the pack_metadata.json file and add notes describing your changes to a new Release Notes file.
To do that, please run the demisto-sdk update-release-notes command - for more information please see: https://xsoar.pan.dev/docs/concepts/demisto-sdk#update-release-notes.
|
Hi @adi88d, |
Status
Description
CP Threat Emulation provides a lower case combinedverdict like "benign". Previous code always set DBot Score to malicious also when it CP Threat Emulation returned a benign verdict. Code change fixes the DBot Score. Code Fix line 849.
Does it break backward compatibility?