Disable cut for live videos

[madmini]

Fixes #801. Greys out the cut button if the duration is 0:00 and on tap shows snackbar "Cutting live videos is not supported".

Another possible approach could be to try to parse the duration as timestamp, and if it does not parse or is 0, disable cutting.

Note that I am not familiar with other reasons for invalid durations such as -1.

[madmini]

hmm job failed, seems there is no signing config, which makes sense for a PR run. But the failed CI did initially scare me 😅

Maybe consider disabling the job entirely for PRs

[deniscerri]

@madmini just because a result has 0 duration doesnt mean its live stream. It could also be a broken extractor. I think it would be better if you wrote it in the likes of
Cutting is not available for this item

[deniscerri]

Also since you added the timestamp check in uiutil you dont have to do it in audio and video fragment
just throw the snack in uiutil and be done with it. keep the cut button disabled in uiutil ofc

[madmini]

okay, but what about the else if(!nonSpecific), which shows a snack with "You need to update the item data in order to be able to use cut feature" and an update button. and during testing this was always the case (and obviously, updating did not change the duration) so i built in the additional check. I had assumed that if there was another error, the duration would be empty or -1.

Is there a proper way to differentiate between an invalid duration and incomplete data?

[deniscerri]

ah yeah, i forgot about items with no current data. Alright then lets keep it as it is, its looks good. Just change the snack text. Thanks buddy

[madmini]

I'd also change the name of the "You need to update the item data in order to be able to use cut feature" from cut_unavailable to cut_unavailable_please_update or similar, if thats okay. Seems easy to confuse with cut_unsupported otherwise.

[deniscerri]

yeah thats fine

[madmini]

feel free to squash ^^