스페이스 전체 뷰 페이지 개발 및 로그인 로직 수정 #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
donghunee,
klmhyeonwoo and
leeminhee119
klmhyeonwoo
approved these changes
Aug 2, 2024
src/app/home/RetrospectViewPage.tsx
Outdated
| if (loading || !hasNextPage) return; | ||
|
|
||
| setLoading(true); | ||
| spaceFetch(cursorId, selectedView, 5) |
src/api/Retrospect/index.ts
Outdated
Comment on lines
13
to
45
| export const spaceFetch = async (cursorId: number, category: string, pageSize: number) => { | ||
| const params = category !== "ALL" ? { cursorId: cursorId, category: category, pageSize: pageSize } : { cursorId: cursorId, pageSize: pageSize }; | ||
|
|
||
| const response = await api.get<SpaceFetchResponse>("/api/space/list", { | ||
| params: params, | ||
| }); | ||
| return response.data; | ||
| }; | ||
|
|
||
| type RestrospectResponse = { | ||
| layerCount: number; | ||
| retrospects: { | ||
| retrospectId: number; | ||
| title: string; | ||
| introduction: string; | ||
| isWrite: boolean; | ||
| retrospectStatus: "PROCEEDING" | "DONE"; | ||
| writeCount: number; | ||
| totalCount: number; | ||
| }[]; | ||
| }; | ||
|
|
||
| // space에 있는 회고록 획득 함수 | ||
| export const spaceRestrospectFetch = async (spaceId: number) => { | ||
| const response = await api.get<RestrospectResponse>(`/space/${spaceId}/retrospect`); | ||
| return response.data; | ||
| }; | ||
|
|
||
| // spaceId에 따른 정보 얻는 함수 | ||
| export const spaceInfoFetch = async (spaceId: number) => { | ||
| const response = await api.get<Space>(`api/space/${spaceId}`); | ||
| return response.data; | ||
| }; |
Member
There was a problem hiding this comment.
추후 tanstack 훅 형태로 변경될 예정 맞을까요?!
| import { Spacing } from "@/component/common/Spacing"; | ||
| import { Typography } from "@/component/common/typography"; | ||
|
|
||
| type RestrospectType = { |
Member
There was a problem hiding this comment.
RetrospectType 이라는 명칭도 물론 좋지만, 공통 Type으로 RetrospectType이라는 친구를 사용하고 있거든요! 회고 유형 자체의 타입을 의미하는! (ex. number / combobox / plain_text ...) 이름이 중복되어서 다른 이름으로 사용해보는것도 좋을 것 같다는 생각입니다! ex) RetrospectBoxType
donghunee
approved these changes
Aug 3, 2024
src/api/Retrospect/index.ts
Outdated
Comment on lines
14
to
20
| const params = category !== "ALL" ? { cursorId: cursorId, category: category, pageSize: pageSize } : { cursorId: cursorId, pageSize: pageSize }; | ||
|
|
||
| const response = await api.get<SpaceFetchResponse>("/api/space/list", { | ||
| params: params, | ||
| }); | ||
| return response.data; | ||
| }; |
Collaborator
There was a problem hiding this comment.
Suggested change
| const params = category !== "ALL" ? { cursorId: cursorId, category: category, pageSize: pageSize } : { cursorId: cursorId, pageSize: pageSize }; | |
| const response = await api.get<SpaceFetchResponse>("/api/space/list", { | |
| params: params, | |
| }); | |
| return response.data; | |
| }; | |
| const response = await api.get<SpaceFetchResponse>("/api/space/list", { | |
| params: { | |
| cursorId, | |
| pageSize, | |
| ...(category !== ALL && { category }) | |
| }, | |
| }); | |
| return response.data; | |
| }; |
요렇게 단순화 할 수 있을 것 같아요..!!
| { viewName: "전체", selected: true }, | ||
| { viewName: "개인", selected: false }, | ||
| { viewName: "팀", selected: false }, | ||
| { viewName: "ALL", selected: true }, |
Collaborator
There was a problem hiding this comment.
viewName type을 string보단 union이나 enum으로 설정하는 것이 좋아보여요~!
leeminhee119
approved these changes
Aug 3, 2024
| return response.data; | ||
| }; | ||
|
|
||
| export const useGetSpaceAndRetrospect = (spaceId?: string): UseQueryOptions<RestrospectResponse, Error, RestrospectResponse, [string]> => ({ |
Member
There was a problem hiding this comment.
파일이름도 동일하게 작성하면 좋을 것 같아요 !!
Comment on lines
+49
to
+52
| if (getSpaceInfo.isSuccess && getRetrospects.isSuccess) { | ||
| setSpaceInfo(getSpaceInfo.data); | ||
| setLayerCount(getRetrospects.data?.layerCount); | ||
| setRestrospectArr(getRetrospects.data?.retrospects); |
Member
There was a problem hiding this comment.
useQuery가 반환하는 데이터를 바로 사용하지 않고 useState로 한 번 더 감싸는 이유가 있을까요 ?!
| }; | ||
|
|
||
| const spaceRestrospectFetch = async (spaceId: string | undefined) => { | ||
| const response = await api.get<RestrospectResponse>(`/space/${spaceId}/retrospect`); |
Member
There was a problem hiding this comment.
헉 여기다 데이터 타입을 지정해주면 되는구나 !! 나도 수정해야게따
Member
There was a problem hiding this comment.
어엇 이거 common에 Tag 있는데 좀 다른 걸까요 ??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏄🏼♂️ Summary (요약)
🫨 Describe your Change (변경사항)
=> 이러한 접근으로 400으로 상태 코드를 수정하였고, 이를 반영하여 코드를 수정했습니다.
🧐 Issue number and link (참고)
📚 Reference (참조)