Conversation
…ient-cognito-identity-provider'
…return CognitoIdpInfo details
…o remove cognito settings
…eArn to shared/base settings
…/CD pipeline workflow
…for better log visibility
…GION from config setting
…yment_and_development
simondib
reviewed
Sep 3, 2024
simondib
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the configuration and improves the deployment reliability to make it easier for users to deploy the system to AWS.
We no longer need to manually copy and paste the API Gateway URL or the Cognito IDP details. This is achieved by running an external FE script
nuxt-load-configuration-settings.tsthat will query AWS for these details and write necessary settings to aconfig/.env.nuxtfile for the FEnuxt.config.tsto use.This has allowed
easy-genomics.yamlfile structure has been simplified to:For end-users, the build and deployment workflow can now be achieved by a single command:
For developers, we still have the convenience to work in parallel on the FE or BE and be able to deploy either separately:
For local FE development, once your BE has been deployed to AWS you can use:
The
nuxt-load-configuration-settings.tsexternal script is run as part of the FE build workflow, and can be manually run by using this shortcutpnpm run nuxt-load-settings. But it does need the BE to be deployed first otherwise it will not find the right API Gateway or Cognito IDP details.NOTE: An external script solution was needed because the project's current JS module setting does support top-level asynchronous calls to be made. If this module is updated to support this, the logic in the
nuxt-load-configuration-settings.tscan be refactored to either the FEmain.tsfile ornuxt.config.ts.