Skip to content

fix(EG-701): params reactivity #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simondib merged 1 commit into from
Sep 19, 2024
Merged

fix(EG-701): params reactivity #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/front-end/src/app/components/EGRunPipelineFormEditParameters.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<script setup lang="ts">
import { ButtonSizeEnum } from '@FE/types/buttons';
import { usePipelineRunStore } from '@FE/stores';

const props = defineProps<{
schema: object;
Expand All @@ -13,9 +14,11 @@

const localProps = reactive({
schema: props.schema,
params: props.params,
params: { ...props.params },
});

const pipelineRunStore = usePipelineRunStore();

onMounted(() => {
// set first section in side panel of UI to active
const definitions = props.schema.definitions;
Expand Down Expand Up @@ -55,7 +58,7 @@
() => localProps.params,
(val) => {
if (val) {
usePipelineRunStore().setParams(val);
pipelineRunStore.setParams(val);
}
},
{ deep: true },
Expand Down Expand Up @@ -98,7 +101,7 @@
:params="localProps.params"
@update:params="
(val) => {
localProps.params = val;
localProps.params = { ...val }; // Ensure reactivity on update
}
"
/>
Expand Down