Conversation
simondib
approved these changes
Oct 8, 2024
…settings_for_deployment
zigtan
deleted the
fix/EG-750_setup_shared_s3_bucket_with_cors_settings_for_deployment
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
data-provisioning-nested-stack.tsto create a single shared S3 Bucket named${this.props.env.account!}-${this.props.namePrefix}-lab-bucketto simulate an existing S3 Bucket for a Lab to select and use.e.g.
{AWS ACCOUNT ID}-dev-quality-lab-bucketIt also removes an unnecessary
s3:CreateBucketIAM policy for thecreate-laboratoryAPI since we are no longer provisioning new S3 Buckets at Lab creation.