Skip to content

feat: run status update redesign#634

Merged
zigtan merged 4 commits intodept:mainfrom
k-florek:feat/run-status-updates
Jul 23, 2025
Merged

feat: run status update redesign#634
zigtan merged 4 commits intodept:mainfrom
k-florek:feat/run-status-updates

Conversation

@k-florek
Copy link
Contributor

feat: run status update redesign

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

This PR includes a new lambda function that handles requests from the front-end to check the status of any run that is not in a terminal state. The lambda function publishes an message to the laboratory run update topic which eventually causes the process-update-laboratory-run to determine the status of the runs. A change was added to the front-end where a table refresh key was added and the fetchLaboratoryRuns() function was removed. This enables the table to be updated and refreshed without the user needing to manually reload the page.

I've also included an unrelated minor bug fix that removes the spaces from samplesheet, which causes problems in a number of pipelines.

Testing

I have tested this with healthomics runs to see the status update changes. I am unsure if any built in validations or tests need to be changed.

Impact

This change solves an issue where runs that take hours - days to complete would have incorrect statuses because AWS would halt the process-update-laboratory-run lambda function due to a recursion limit. This update circumvents this by removing the recursion from process-update-laboratory-run and moving the logic to the front-end to periodically check for status updates.

Additional Information

I believe I have added this new functionality to be inline with the project design, however it is likely I overlooked something in this implementation. So please review with care.

Checklist

  • No new errors or warnings have been introduced.
  • All tests pass successfully and new tests added as necessary.
  • Documentation has been updated accordingly.
  • Code adheres to the coding and style guidelines of the project.
  • Code has been commented in particularly hard-to-understand areas.

@zigtan zigtan self-requested a review July 13, 2025 23:46
Copy link
Contributor

@zigtan zigtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @k-florek ! Nice work on adding the new API and fixing the sample sheet format.

If the status update check hits performance limits with Seqera's APIs we might need to revisit the solution.

Feel free to squash and merge your PR when you are available.

@zigtan zigtan merged commit b6f7a2f into dept:main Jul 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants