Merged
Conversation
zigtan
approved these changes
Jul 13, 2025
Contributor
There was a problem hiding this comment.
Thanks @k-florek ! Nice work on adding the new API and fixing the sample sheet format.
If the status update check hits performance limits with Seqera's APIs we might need to revisit the solution.
Feel free to squash and merge your PR when you are available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: run status update redesign
Type of Change
Description
This PR includes a new lambda function that handles requests from the front-end to check the status of any run that is not in a terminal state. The lambda function publishes an message to the laboratory run update topic which eventually causes the process-update-laboratory-run to determine the status of the runs. A change was added to the front-end where a table refresh key was added and the fetchLaboratoryRuns() function was removed. This enables the table to be updated and refreshed without the user needing to manually reload the page.
I've also included an unrelated minor bug fix that removes the spaces from samplesheet, which causes problems in a number of pipelines.
Testing
I have tested this with healthomics runs to see the status update changes. I am unsure if any built in validations or tests need to be changed.
Impact
This change solves an issue where runs that take hours - days to complete would have incorrect statuses because AWS would halt the process-update-laboratory-run lambda function due to a recursion limit. This update circumvents this by removing the recursion from process-update-laboratory-run and moving the logic to the front-end to periodically check for status updates.
Additional Information
I believe I have added this new functionality to be inline with the project design, however it is likely I overlooked something in this implementation. So please review with care.
Checklist