feat(EG-444): improve user organization access#77
Merged
Conversation
…ta to support Status
…ccess enhancement
…onAccess enhancement
…onAccess enhancement
…Access enhancement
simondib
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an enhancement to the User API changes that introduces the
OrganizationAccessmetadata to efficiently return theUser'scurrent list ofOrganizationsandLaboratoriesthey have been granted access to.This enhancement modifies the
OrganizationAccessdata structure to include the OrganizationUser Status and LaboratoryUser Status.It also updates the
edit-organization-userandedit-laboratory-userAPIs to make use of the respective PlatformUserService functions:editExistingUserAccessToOrganization()editExistingUserAccessToLaboratory()The updating of a User's OrganizationUser Status to
Inactivedoes not cascade to update the associatedLaboratories, as the intent of theInactivestatus is meant to be a non-destructive way of disabling a user's access to an Organization. Once the User's OrganizationUser Status is updated toActiveagain, the existing Laboratories access should be immediately available to the User.The deletion of a User's OrganizationUser record (i.e. using the
remove-organization-userAPI) is intended to be destructive, and will cascade to remove the associated LaboratoryUser access mapping records.