Skip to content

Comments

feat(EG-444): improve user organization access#77

Merged
zigtan merged 10 commits intomainfrom
feat/EG-444-improve_User_OrganizationAccess
May 20, 2024
Merged

feat(EG-444): improve user organization access#77
zigtan merged 10 commits intomainfrom
feat/EG-444-improve_User_OrganizationAccess

Conversation

@zigtan
Copy link
Contributor

@zigtan zigtan commented May 20, 2024

This PR is an enhancement to the User API changes that introduces the OrganizationAccess metadata to efficiently return the User's current list of Organizations and Laboratories they have been granted access to.

This enhancement modifies the OrganizationAccess data structure to include the OrganizationUser Status and LaboratoryUser Status.

It also updates the edit-organization-user and edit-laboratory-user APIs to make use of the respective PlatformUserService functions:

  • editExistingUserAccessToOrganization()
  • editExistingUserAccessToLaboratory()

The updating of a User's OrganizationUser Status to Inactive does not cascade to update the associated Laboratories, as the intent of the Inactive status is meant to be a non-destructive way of disabling a user's access to an Organization. Once the User's OrganizationUser Status is updated to Active again, the existing Laboratories access should be immediately available to the User.

The deletion of a User's OrganizationUser record (i.e. using the remove-organization-user API) is intended to be destructive, and will cascade to remove the associated LaboratoryUser access mapping records.

Copy link
Contributor

@simondib simondib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @zigtan!

@zigtan zigtan merged commit ce0ca44 into main May 20, 2024
@zigtan zigtan deleted the feat/EG-444-improve_User_OrganizationAccess branch May 20, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants