This repository was archived by the owner on Mar 19, 2021. It is now read-only.
Support aXe-core 3.0 Shadow DOM selectors#49
Merged
WilcoFiers merged 3 commits intodevelopfrom Feb 21, 2018
Merged
Conversation
Contributor
|
I really wish we had more tests for this project! Any way we can add them with this change to make sure it works? |
WilcoFiers
force-pushed
the
shadowdom
branch
from
afdbb2b to
b20c7ba
Compare
Contributor
Author
|
@marcysutton You're quite right. I've added an integration test showing it picks up shadow DOM elements. |
Contributor
|
@WilcoFiers I think you need to upgrade the Node version on Circle, transpile with Babel, or use more stable JS APIs. |
WilcoFiers
force-pushed
the
shadowdom
branch
from
b20c7ba to
940f9d2
Compare
Contributor
Author
|
Sorted. Sorry Marcy, bit of an oversight on my part. |
marcysutton
approved these changes
Feb 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.