Allow handle to be an array of HTMLElement#166
Closed
kftang wants to merge 1 commit intodesandro:masterfrom
Closed
Allow handle to be an array of HTMLElement#166kftang wants to merge 1 commit intodesandro:masterfrom
kftang wants to merge 1 commit intodesandro:masterfrom
Conversation
Owner
|
Thank you for this contribution! I like how this is a nice improvement. I like the feature, but I might implement differently to match Draggabilly's code style. I'll follow up in a subsequent release. |
desandro
added a commit
that referenced
this pull request
Dec 29, 2021
- remove RequireJS docs - version bump in README
Owner
|
Draggabilly v3 has been released, now with updated // select all .handle children with selector string
handle: '.handle'
// set as element
handle: element.querySelector('.handle')
// set as array or NodeList
handle: [ element.querySelector('.handle1'), element.querySelector('.handle2') ]Please try it out and report back with any issues! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using Vue.js and found it to be quite difficult to get a selector string from an HTMLElement so something like this could make it much easier.