Conversation
|
✅ Code review completed successfully |
There was a problem hiding this comment.
🐕 Shuni's Review
Version bump PR: web component 3.8.10 → 3.56.0, SDK 0.9.13 → 0.9.14. Also refactors the web component version into a constant for easier future bumps.
LGTM — no issues found. Clean version bump with a nice DRY improvement in _addFlowScriptToPage. Good bones! 🦴
There was a problem hiding this comment.
Pull request overview
This PR bumps the Descope Flutter package version to 0.9.14 and updates the embedded Flutter web flow to load Descope’s web component 3.56.0, aligning package metadata, runtime version reporting, and changelog entries.
Changes:
- Bump Flutter package/SDK version from
0.9.13to0.9.14. - Update Flutter web flow script injection to use Descope web component version
3.56.0(and derive the script tag class name from the version). - Add a
0.9.14changelog entry documenting the web component bump.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pubspec.yaml | Updates package version to 0.9.14. |
| lib/src/sdk/sdk.dart | Updates DescopeSdk.version to 0.9.14. |
| lib/src/internal/routes/flow.dart | Introduces _webComponentVersion = 3.56.0 and uses it in the injected web component script tag and class name. |
| CHANGELOG.md | Adds release notes for 0.9.14 describing the component bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related Issues
Fixes https://github.com/descope/etc/issues/14338
Description