Handle builds against various python versions with cibuildwheel#34
Merged
peytondmurray merged 1 commit intodeshaw:mainfrom Mar 20, 2026
Merged
Handle builds against various python versions with cibuildwheel#34peytondmurray merged 1 commit intodeshaw:mainfrom
peytondmurray merged 1 commit intodeshaw:mainfrom
Conversation
mlucool
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with uploading our wheels to PyPI.
I'm really not sure why this change works, but I noticed that
maturin.bindings = 'bin'inpyproject.toml). As a result the wheels are compatible with all python versionsAgain, I'm not sure why PyPI is rejecting our wheels if we build them one-by-one, but given that this is a perfectly valid way of building these, I'm fine with this change.