Skip to content

Conversation

@haoozhang
Copy link
Contributor

Description of Changes

add websphere and weblogic framework detector

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

Acceptance Criteria

Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.

  • Unit/Functional tests

  • Documentation

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haoozhang thanks again for your contribution!

Again here I think we could reduce the size of the test resources. I would also appreciate if you could include doc updates so we are sure that they stay up-to-date.

Overall functionality wise it looks good

HaoZhang added 2 commits January 12, 2026 11:22
@haoozhang
Copy link
Contributor Author

haoozhang commented Jan 12, 2026

@haoozhang thanks again for your contribution!

Again here I think we could reduce the size of the test resources. I would also appreciate if you could include doc updates so we are sure that they stay up-to-date.

Overall functionality wise it looks good

Removed the unnecessary test files and updated the doc. Please help to review again.

@haoozhang haoozhang requested a review from thepetk January 12, 2026 03:32
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 12, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoozhang, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit dc80e77 into devfile:main Jan 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants