Skip to content

Refactor ctor and implicit conversions as template-based#19

Merged
kzu merged 1 commit intomainfrom
dev/ctor
Nov 29, 2024
Merged

Refactor ctor and implicit conversions as template-based#19
kzu merged 1 commit intomainfrom
dev/ctor

Conversation

@kzu
Copy link
Copy Markdown
Member

@kzu kzu commented Nov 29, 2024

This simplifies mantainability down the road.

This also allowed conditional generation of the primary constructor if users already provide one with the required Value parameter. A pair of codefixes are provided to either remove a non-compliant ctor entirely or renaming the parameter to Value as required.

@kzu kzu added the enhancement New feature or request label Nov 29, 2024
This simplifies mantainability down the road.

This also allowed conditional generation of the primary constructor if users already provide one with the required Value parameter. A pair of codefixes are provided to either remove a non-compliant ctor entirely or renaming the parameter to `Value` as required.
@devlooped-bot
Copy link
Copy Markdown
Member

devlooped-bot commented Nov 29, 2024

30 passed 30 passed

🧪 Details on Microsoft Windows 10.0.20348

✅ StructId.ComparableGeneratorTests.GenerateComparable
✅ StructId.ComparableGeneratorTests.GenerateStringParseable
✅ StructId.ConstructorGeneratorTests.GenerateRecordConstructor
✅ StructId.ConstructorGeneratorTests.GenerateRecordConstructorInGlobalNamespace
✅ StructId.ConstructorGeneratorTests.GenerateRecordStringConstructor
✅ StructId.Functional.FunctionalTests.Dapper
✅ StructId.Functional.FunctionalTests.EntityFramework
✅ StructId.Functional.FunctionalTests.EqualityTest
✅ StructId.Functional.FunctionalTests.ImplicitAndExplicitCast
✅ StructId.Functional.FunctionalTests.Newtonsoft
✅ StructId.NewtonsoftJsonGeneratorTests.DoesNotGenerateIfNewtonsoftJsonNotPresent
✅ StructId.NewtonsoftJsonGeneratorTests.GenerateIfNewtonsoftJsonPresent
✅ StructId.ParsableGeneratorTests.GenerateParseable
✅ StructId.ParsableGeneratorTests.GenerateStringParseable
✅ StructId.ParsableGeneratorTests.NoParseableAvailable
✅ StructId.RecordAnalyzerTests.ClassNotStructId
✅ StructId.RecordAnalyzerTests.PartialRecordStructNotReadonly
✅ StructId.RecordAnalyzerTests.PartialStringRecordStructNotReadonly
✅ StructId.RecordAnalyzerTests.ReadonlyRecordStructNoStructId
✅ StructId.RecordAnalyzerTests.ReadonlyRecordStructNotPartial
✅ StructId.RecordAnalyzerTests.ReadonlyRecordStructWithNonValueConstructor
✅ StructId.RecordAnalyzerTests.ReadonlyStringRecordStructNotPartial
✅ StructId.RecordAnalyzerTests.RecordStructNoStructId
✅ StructId.RecordAnalyzerTests.RecordStructNotReadonlyNorPartial
✅ StructId.RecordAnalyzerTests.StructNotStructId
✅ StructId.RecordCodeFixTests.AddPartialKeyword
✅ StructId.RecordCodeFixTests.AddReadOnlyModifier
✅ StructId.RecordCodeFixTests.ChangeRecordStruct
✅ StructId.RecordCtorCodeFixTests.RemoveCtor
✅ StructId.RecordCtorCodeFixTests.RenameValue

from dotnet-retest v0.6.3 on .NET 8.0.11 with 💜

@kzu kzu merged commit 84be9a3 into main Nov 29, 2024
@kzu kzu deleted the dev/ctor branch November 29, 2024 02:17
@devlooped devlooped locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants