connector/saml: implement SP-Initiated Single Logout via LogoutCallbackConnector#4742
Draft
Jabejixo wants to merge 2 commits intodexidp:masterfrom
Draft
connector/saml: implement SP-Initiated Single Logout via LogoutCallbackConnector#4742Jabejixo wants to merge 2 commits intodexidp:masterfrom
Jabejixo wants to merge 2 commits intodexidp:masterfrom
Conversation
Signed-off-by: Ivan Zvyagintsev <ivan.zvyagintsev@flant.com>
Signed-off-by: Ivan Zvyagintsev <ivan.zvyagintsev@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add SAML Single Logout (SLO) support to the SAML connector by implementing
the
LogoutCallbackConnectorinterface from #4674.What this PR does / why we need it
The SAML connector does not support Single Logout - when a user logs out
through Dex, the upstream IdP session stays active.
This PR adds two methods to the SAML connector:
LogoutURL- builds a<LogoutRequest>with HTTP-Redirect binding(DEFLATE + base64) using
NameIDandSessionIndexcaptured during login.HandleLogoutCallback- validates the IdP's<LogoutResponse>for bothHTTP-Redirect (GET) and HTTP-POST bindings with binding-aware signature
validation.
New config fields:
sloURL(IdP's SLO endpoint) andinsecureSkipSLOSignatureValidation. Existingca/caDatacertificatesare reused - no additional configuration required.
Special notes for your reviewer
LogoutCallbackConnectorinterface called by
logout.go.NameID,NameIDFormat, andSessionIndexare persisted inConnectorDataduring
HandlePOSTalongside the existing refresh token fields.nameID.FormatXML tag was missingattr— it is anattribute, not a child element.
Signature/SigAlgquery params) isimplemented separately from embedded XML signatures.