Fix switching identity in dashboard. #3484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuntaner
approved these changes
Nov 10, 2025
Contributor
lmuntaner
left a comment
lmuntaner
left a comment
There was a problem hiding this comment.
Thanks for the E2E test!
Minor comment only, already approving.
| const handleSignIn = async (identityNumber: bigint) => { | ||
| lastUsedIdentitiesStore.selectIdentity(identityNumber); | ||
| await gotoManage(); | ||
| const switchedToIdentity = async (identityNumber: bigint) => { |
Contributor
There was a problem hiding this comment.
Why switched and not switch?
Contributor
Author
There was a problem hiding this comment.
Since this method is technically called after the user has already authenticated with another identity, thus switched identity.
For example it's called in handleSwitchIdentity after authentication with the next identity.
Contributor
Author
There was a problem hiding this comment.
But since we're calling.selectIdentity() in this method, switch might actually read better than switched.
| await expect(passkey).toHaveCount(1); | ||
| }); | ||
|
|
||
| test("User can switch between identities", async ({ page }) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix switching identity in dashboard.
Changes
gotoManagemethod withswitchedToIdentitymethod.$lastUsedIdentitiesStore.identitiesis astring, so usingtoStringinstead inhandleSwitchIdentity.Tests
Added e2e test to make sure page data is updated when identity is switched.