Skip to content

Conversation

@aterga
Copy link
Contributor

@aterga aterga commented Nov 19, 2025

Motivation

Context. The migration has been patched to gracefully handle anchor memory corruption, and the canister has been fixed to not allocate new dangling anchors. Now the integration test needs to be adjuster to reflect that there is no way to introduce this issue using the latest canister version.

Changes

  • No longer attempt to allocate dangling anchors in sync_anchor_indices_migration.

Tests

  • The test in question (sync_anchor_indices_migration) has been adjusted accordingly.

@aterga aterga marked this pull request as ready for review November 19, 2025 16:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the sync_anchor_indices_migration test to reflect a recent bug fix that prevents the creation of dangling anchors. The test previously attempted to create a dangling anchor by using an excessively long name, but with the fix in place, this is no longer possible.

  • Simplified anchor creation loop to create all anchors with valid names
  • Updated expected recovery phrase count to match all created anchors
  • Updated smoke test expectation for pub-key-0 to have an anchor
Comments suppressed due to low confidence (1)

src/internet_identity/tests/integration/upgrade.rs:12

  • This import is unused and should be removed. The code does not reference the authn_method module anywhere in the file.
use internet_identity_interface::internet_identity::types::*;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@sea-snake sea-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aterga aterga added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 3071105 Nov 19, 2025
172 of 189 checks passed
@aterga aterga deleted the arshavir/adjust-test_sync_anchor_indices_migration branch November 19, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants