-
Notifications
You must be signed in to change notification settings - Fork 164
Update create recovery phrase views #3510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y to match design. The error and reset views will be updated in another PR.
Screen.Recording.2025-11-20.at.18.48.02.mov |
lmuntaner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Some minor questions, but already approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the name a bit confusing, initially I thought it was the steps in the top of the wizard. I didn't understand it as a loading or spinner. Maybe LoadingSteps would be more accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll name it StepsProgressBar (in another PR).
| </button> | ||
| </div> | ||
| <Button onclick={onWritten}>{$t`I have written it down`}</Button> | ||
| <Button onclick={onWritten} disabled={!isRevealed} size="lg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No button to copy all the words at once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not in the design, neither would that align with what the interface is telling the user (store offline). Nonetheless, I made sure that you can still reliably select all words and copy to clipboard for those few power users that choose to ignore those warnings.
Update create recovery phrase happy path views and their functionality to match design. The error and reset views will be updated in a follow-up PR.
Changes
Acknowledge,WriteandVerifyviews to match design and rewrote it's copy.Verifyview.Stepscomponent to indicate the user journey through the recovery phrase set-up.StepsProgresscomponent that's used as an animated replacement of the above to indicate loading/waiting.Checkboxcomponent (it's already on the outer wrapper).Tests
The e2e tests will be added in a later follow-up PR.