Skip to content

Conversation

@sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Nov 20, 2025

Update create recovery phrase happy path views and their functionality to match design. The error and reset views will be updated in a follow-up PR.

Changes

  • Updated Acknowledge, Write and Verify views to match design and rewrote it's copy.
  • Implement ordered selection logic in Verify view.
  • Implement Steps component to indicate the user journey through the recovery phrase set-up.
  • Implement StepsProgress component that's used as an animated replacement of the above to indicate loading/waiting.
  • Remove erroneous classname from Checkbox component (it's already on the outer wrapper).

Tests

The e2e tests will be added in a later follow-up PR.

@sea-snake
Copy link
Contributor Author

Screen.Recording.2025-11-20.at.18.48.02.mov

@sea-snake sea-snake requested a review from lmuntaner November 20, 2025 19:59
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some minor questions, but already approving.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the name a bit confusing, initially I thought it was the steps in the top of the wizard. I didn't understand it as a loading or spinner. Maybe LoadingSteps would be more accurate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll name it StepsProgressBar (in another PR).

</button>
</div>
<Button onclick={onWritten}>{$t`I have written it down`}</Button>
<Button onclick={onWritten} disabled={!isRevealed} size="lg">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No button to copy all the words at once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not in the design, neither would that align with what the interface is telling the user (store offline). Nonetheless, I made sure that you can still reliably select all words and copy to clipboard for those few power users that choose to ignore those warnings.

@sea-snake sea-snake added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit 3ff61be Nov 21, 2025
147 of 196 checks passed
@sea-snake sea-snake deleted the sea-snake/create-recovery-happy-path-views branch November 21, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants