Skip to content

chore!: bump ic-cdk to v0.19.0#251

Merged
lpahlavi merged 13 commits intomainfrom
lpahlavi/bump-ic-cdk-to-v0.19.0
Dec 11, 2025
Merged

chore!: bump ic-cdk to v0.19.0#251
lpahlavi merged 13 commits intomainfrom
lpahlavi/bump-ic-cdk-to-v0.19.0

Conversation

@lpahlavi
Copy link
Contributor

@lpahlavi lpahlavi commented Nov 24, 2025

(DEFI-2398) Bump ic-cdk to v0.19.0 and use the ic_canister_runtime::IcError type instead of the legacy (RejectionCode, String) in the sol_rpc_client. Also bump Rust to v1.90.0, pocket-ic to v11.0.0 and ic-metrics-assert to v0.3.0.

BREAKING CHANGE: This change is breaking as it changes the error type returned by the sol_rpc_client::SolRpcClient from (RejectionCode, String) to ic_canister_runtime::IcError.

@lpahlavi lpahlavi force-pushed the lpahlavi/bump-ic-cdk-to-v0.19.0 branch from 6fab5c2 to ca331a3 Compare November 24, 2025 16:20
@lpahlavi lpahlavi changed the base branch from main to lpahlavi/standalone-basic-solana November 24, 2025 16:21
@lpahlavi lpahlavi marked this pull request as ready for review November 24, 2025 16:27
@lpahlavi lpahlavi changed the title chore!: Bump ic-cdk to v0.19.0 chore!: bump ic-cdk to v0.19.0 Nov 24, 2025
Base automatically changed from lpahlavi/standalone-basic-solana to main November 28, 2025 07:47
@lpahlavi lpahlavi changed the base branch from main to lpahlavi/do-not-serialize-none November 28, 2025 09:18
@lpahlavi lpahlavi force-pushed the lpahlavi/bump-ic-cdk-to-v0.19.0 branch 2 times, most recently from 41a1125 to 2a619bb Compare December 8, 2025 11:00
@lpahlavi lpahlavi force-pushed the lpahlavi/bump-ic-cdk-to-v0.19.0 branch from 2a619bb to 64dc327 Compare December 8, 2025 13:37
@lpahlavi lpahlavi changed the title chore!: bump ic-cdk to v0.19.0 chore!: bump ic-cdk to v0.19.0 and Rust to v1.90.0 Dec 8, 2025
@lpahlavi lpahlavi changed the title chore!: bump ic-cdk to v0.19.0 and Rust to v1.90.0 chore!: bump ic-cdk to v0.19.0 Dec 8, 2025
@lpahlavi lpahlavi changed the base branch from lpahlavi/do-not-serialize-none to main December 8, 2025 16:17
@lpahlavi lpahlavi requested review from mducroux and removed request for gregorydemay December 9, 2025 12:17
Copy link
Contributor

@mducroux mducroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bump @lpahlavi. Only a few minor comments.

@lpahlavi lpahlavi requested a review from a team December 10, 2025 06:25
@lpahlavi lpahlavi requested a review from mducroux December 10, 2025 06:49
@lpahlavi
Copy link
Contributor Author

Thanks a lot for the review @mducroux! This should be ready for another round 🚀

@lpahlavi lpahlavi requested a review from mducroux December 10, 2025 14:26
Copy link
Contributor

@mducroux mducroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @lpahlavi! LGTM

@lpahlavi lpahlavi merged commit 69d633c into main Dec 11, 2025
16 checks passed
@lpahlavi lpahlavi deleted the lpahlavi/bump-ic-cdk-to-v0.19.0 branch December 11, 2025 08:18
@github-actions github-actions bot mentioned this pull request Jan 12, 2026
lpahlavi added a commit that referenced this pull request Jan 12, 2026
## 🤖 New release

* `sol_rpc_types`: 3.0.0 -> 4.0.0
* `sol_rpc_canister`: 1.3.0
* `sol_rpc_client`: 3.0.0 -> 3.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `sol_rpc_types`

<blockquote>

## [3.1.0] - 2026-01-12

### Changed

- Bump `ic-cdk` to v0.19.0
([#251](#251))
- Upgrade various dependencies
([#260](#260))

[3.1.0]:
https://github.com/dfinity/sol-rpc-canister/compare/3.0.0..3.1.0
</blockquote>

## `sol_rpc_canister`

<blockquote>

## [1.3.0] - 2026-01-12

### Changed

- Bump `ic-cdk` to v0.19.0
([#251](#251))
- Upgrade various dependencies
([#260](#260))

### Fixed

- Do not ignore `response_size_estimate` for `getBlock` endpoint
([#236](#236))

[1.3.0]:
sol_rpc_canister-v1.2.0...sol_rpc_canister-v1.3.0
</blockquote>

## `sol_rpc_client`

<blockquote>

## [4.0.0] - 2026-01-12

### Changed

- Use `ic_canister_runtime::Runtime` instead of local `Runtime` trait
([#248](#248))
- **BREAKING:** Bump `ic-cdk` to v0.19.0. See PR description for more
details on the breaking changes.
([#251](#251))
- Upgrade various dependencies
([#260](#260))

### Fixed

- **BREAKING:** Calculate default request cost before sending. See PR
description for more details on the breaking changes.
([#256](#256))

[4.0.0]:
https://github.com/dfinity/sol-rpc-canister/compare/3.0.0..4.0.0
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Louis Pahlavi <louis.pahlavi@dfinity.org>
Co-authored-by: Louis Pahlavi <louis.pahlavi@gmail.com>
@github-actions github-actions bot mentioned this pull request Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants