build: migrate dependencies to solana-sdk repository#55
Merged
Conversation
lpahlavi
force-pushed
the
lpahlavi/forked-sdk-dependencies
branch
from
6ea313f to
5490fe9
Compare
This reverts commit 0dd97d0.
lpahlavi
changed the title
solana-sdk repository
gregorydemay
reviewed
Jul 4, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks @lpahlavi for this PR! Some minor comments.
Contributor
Author
|
Thanks a lot for having a look @gregorydemay! I believe I should have addressed all of your comments. |
gregorydemay
approved these changes
Jul 4, 2025
Closed
Merged
lpahlavi
added a commit
that referenced
this pull request
Jul 31, 2025
## 🤖 New release
* `sol_rpc_types`: 1.0.0 -> 2.0.0 (⚠ API breaking changes)
* `sol_rpc_canister`: 1.0.0 -> 1.1.0 (✓ API compatible changes)
* `sol_rpc_client`: 1.0.0 -> 2.0.0 (⚠ API breaking changes)
### ⚠ `sol_rpc_types` breaking changes
```text
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---
Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/constructible_struct_adds_field.ron
Failed in:
field TransactionStatusMeta.cost_units in /tmp/.tmpuppblp/sol-rpc-canister/libs/types/src/solana/transaction/mod.rs:286
```
<details><summary><i><b>Changelog</b></i></summary><p>
## `sol_rpc_types`
<blockquote>
## [2.0.0] - 2025-07-31
### Added
- Add optional `cost_units` to `TransactionStatusMeta`
([#180](#180))
- Add build requirements to READMEs and rustdoc
([#169](#169))
- Add `Cargo.toml` linting to CI pipeline
([#155](#155))
### Changed
- Require HTTP outcall base fee
([#185](#185))
- Select supported providers based on successful responses
([#183](#183))
- Migrate dependencies to `solana-sdk` repository
([#55](#55))
- Improve docs for `InstallArgs`
([#172](#172))
[2.0.0]:
https://github.com/dfinity/sol-rpc-canister/compare/1.0.0..2.0.0
</blockquote>
## `sol_rpc_canister`
<blockquote>
## [1.1.0] - 2025-07-31
### Added
- Add optional `cost_units` to `TransactionStatusMeta` (#180)
- Add more metrics (#144)
### Changed
- Do not record metrics for requests with insufficient cycles (#184)
- Require HTTP outcall base fee (#185)
- Select supported providers based on successful responses (#183)
### Fixed
- Change `nat16` to `nat32` in examples (#151)
</blockquote>
## `sol_rpc_client`
<blockquote>
## [2.0.0] - 2025-07-31
### Added
- Add `try_send` method to SOL RPC client
([#187](#187))
- Add build requirements to READMEs and rustdoc
([#169](#169))
- Add `Cargo.toml` linting to CI pipeline
([#155](#155))
### Changed
- Revert `sol_rpc_client` bump
([#178](#178))
- Migrate dependencies to `solana-sdk` repository
([#55](#55))
- Bump `sol_rpc_client` to `v1.0.1`
([#164](#164))
- Enable `ed25519` feature in docs
([#162](#162))
### Fixed
- Use correct fee for t-sig with local development key
([#160](#160))
[2.0.0]:
https://github.com/dfinity/sol-rpc-canister/compare/1.0.0..2.0.0
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Louis Pahlavi <louis.pahlavi@dfinity.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Why this change?
Previously, we relied on patched dependencies from the
anza-xyz/agaverepository. However, the Solana SDK has since been migrated toanza-xyz/solana-sdk, making the old patch target obsolete.Additionally, our workspace
Cargo.tomlspecified patched dependencies using semver-compatible version ranges, such as:This works fine during
cargo build, because patched versions from the fork are prioritized. But when runningcargo publish, Cargo ignores the patches and resolves the latest semver-compatible upstream version instead (e.g.,v2.3.2), which may introduce breaking changes. For example, inv2.3.1of thesolana-account-decoder-client-typescrate, a new (optional)cost_unitsfield was added toUiTransactionStatusMeta, causing compilation failures at publish time.✅ What’s the fix?
anza-xyz/solana-sdkfork=to avoid semver drift:This ensures reproducible builds and a smooth
cargo publishprocess for the SOL RPC canister crate.