Skip to content

fix(live): fix how xidmap stores value along with upsertPredicate#9309

Merged
mangalaman93 merged 2 commits intomainfrom
harshil-goel/live-loader-perf
Apr 23, 2025
Merged

fix(live): fix how xidmap stores value along with upsertPredicate#9309
mangalaman93 merged 2 commits intomainfrom
harshil-goel/live-loader-perf

Conversation

@ghost
Copy link

@ghost ghost commented Feb 17, 2025

No description provided.

@ghost ghost self-requested a review February 17, 2025 09:01
@github-actions github-actions bot added area/live-loader Issues related to live loading. area/core internal mechanisms go Pull requests that update Go code labels Feb 17, 2025
@trunk-io
Copy link

trunk-io bot commented Feb 17, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

Flaky Test Failure Summary Logs
TestCurlAccessWithoutClientCert The curl command failed with an error: OpenSSL/3.0.13: error:0A00010B:SSL routines::wrong version number. Logs ↗︎

View Full Report ↗︎Docs

@ryanfoxtyler ryanfoxtyler added area/api our HTTP endpoints and removed area/api our HTTP endpoints labels Feb 18, 2025
@ryanfoxtyler ryanfoxtyler marked this pull request as draft February 18, 2025 13:51
@ryanfoxtyler ryanfoxtyler marked this pull request as ready for review February 18, 2025 13:51
@ghost ghost force-pushed the harshil-goel/live-loader-perf branch from 8921ec7 to 750c8b2 Compare March 6, 2025 16:17
@ghost ghost force-pushed the harshil-goel/live-loader-perf branch from 750c8b2 to 82c2d9f Compare April 10, 2025 04:34
mangalaman93
mangalaman93 previously approved these changes Apr 17, 2025
Copy link
Contributor

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor changes, LGTM!

@mangalaman93 mangalaman93 merged commit 1193c84 into main Apr 23, 2025
13 checks passed
@mangalaman93 mangalaman93 deleted the harshil-goel/live-loader-perf branch April 23, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core internal mechanisms area/live-loader Issues related to live loading. go Pull requests that update Go code

Development

Successfully merging this pull request may close these issues.

3 participants