fix(zero): make zero shutdown cleanly#9525
Merged
matthewmcneely merged 3 commits intodgraph-io:mainfrom Dec 30, 2025
Merged
Conversation
xqqp
force-pushed
the
fix_zero_shutdown
branch
from
ee56b98 to
9334cda
Compare
xqqp
force-pushed
the
fix_zero_shutdown
branch
2 times, most recently
from
2bdc328 to
13978f2
Compare
xqqp
force-pushed
the
fix_zero_shutdown
branch
from
13978f2 to
2569fee
Compare
xqqp
force-pushed
the
fix_zero_shutdown
branch
2 times, most recently
from
90d48a5 to
440f014
Compare
xqqp
force-pushed
the
fix_zero_shutdown
branch
from
440f014 to
a3f364c
Compare
matthewmcneely
force-pushed
the
fix_zero_shutdown
branch
from
06e13ab to
f8b5dad
Compare
matthewmcneely
approved these changes
Dec 30, 2025
Contributor
matthewmcneely
left a comment
matthewmcneely
left a comment
There was a problem hiding this comment.
Thanks @xqqp. It's nice to have the zero's shutting down gracefully again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero currently has several issues related to shutdown:
updateEnterpriseState()without decreasing the wait group counter. This makes zero wait indefinitely, or exit with a return code other than zero after it has been forced to terminate.time.Sleep, so even if pools would get shutdown, the shutdown would be delayed by the remaining sleep duration.This PR sets the appropriate wait group counter, implements a function which removes pools on shutdown and switches from
time.Sleeptotime.Tickin the health check.