Closed
Conversation
Open
Member
|
Hmm this appear a bit suspect, how does it work out in vanila with out the breaks? |
Member
Author
|
Poopcode I'd say |
Contributor
|
Since the switch statement and the if-if-if statements do exactly the same thing, I've added the unlikely code change label. It may very well be the case that they did rewrite an if-if-if-if statement into a switch statement for v1.09b. However, until we've checked against other versions of Diablo, I'll leave this as unlikely. |
Contributor
|
May be they want to get ride of few integer comparison thanks to the break statement ? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.