Skip to content

[hellfire] AddMisexp bin exact#1465

Closed
qndel wants to merge 1 commit intodiasurgical:hellfirefrom
qndel:AddMisexp
Closed

[hellfire] AddMisexp bin exact#1465
qndel wants to merge 1 commit intodiasurgical:hellfirefrom
qndel:AddMisexp

Conversation

@qndel
Copy link
Member

@qndel qndel commented Aug 30, 2019

No description provided.

@AJenbo
Copy link
Member

AJenbo commented Aug 31, 2019

Hmm this appear a bit suspect, how does it work out in vanila with out the breaks?

@qndel
Copy link
Member Author

qndel commented Aug 31, 2019

Poopcode I'd say

@mewmew
Copy link
Contributor

mewmew commented Oct 7, 2019

Since the switch statement and the if-if-if statements do exactly the same thing, I've added the unlikely code change label. It may very well be the case that they did rewrite an if-if-if-if statement into a switch statement for v1.09b. However, until we've checked against other versions of Diablo, I'll leave this as unlikely.

@mmaret
Copy link
Contributor

mmaret commented Oct 15, 2019

May be they want to get ride of few integer comparison thanks to the break statement ? :)

@AJenbo AJenbo closed this Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants