Merged
Conversation
qndel
added
Binary exact
code cleanup
Open
mewmew
reviewed
Sep 5, 2019
| missile[i]._miVar1 = missile[i]._mix; | ||
| missile[i]._miVar2 = missile[i]._miy; | ||
| ChangeLight(missile[i]._mlid, missile[i]._mix, missile[i]._miy, 5); | ||
| ChangeLight(missile[i]._mlid, missile[i]._miVar1, missile[i]._miVar2, 5); |
Contributor
There was a problem hiding this comment.
Does this mean that it was incorrect in vanilla? Prior to changing the field _mix to _miVar1?
There was a problem hiding this comment.
No, it was just poor decompilation due to optimizing. It is assigned to the same variables right above it i.e. missile[i]._miVar1 = missile[i]._mix;. So likely _mix is put in a register and then pushed afterwards for minimum size.
Contributor
There was a problem hiding this comment.
Right. This rings a bell somehow. Thanks for explaining it to me (perhaps for the second time, seeing as I have a deja vu feeling).
Member
There was a problem hiding this comment.
There have been a few PRs like this one today 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin exact in vanilla and hellfire