[hellfire] ProcessMissiles bin exact#1568
Merged
AJenbo merged 1 commit intodiasurgical:hellfirefrom Sep 8, 2019
Merged
Conversation
Open
AJenbo
reviewed
Sep 8, 2019
| #ifdef HELLFIRE | ||
| if (missile[missileactive[i]]._miDelFlag == TRUE) { | ||
| #else | ||
| if (missile[missileactive[i]]._miDelFlag) { |
Member
There was a problem hiding this comment.
can you check if != FALSE works for both
Member
There was a problem hiding this comment.
I wonder if maybe _miDelFlag was changed from BOOL to bool and that's the difference?
Member
Author
There was a problem hiding this comment.
well, the asm in hellfire says cmp dword ptr [eax+0x697A8C], 0x01
Member
There was a problem hiding this comment.
What an ugly and useless refactor :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.