Multiple exports

[kdschaffe]

Why do you have the models exporting in es2015 and commonjs formats?

See: https://github.com/diegohaz/generator-rest/blob/master/generators/api/templates/model.js#L48

[diegohaz]

Hi, @kdschaffe.

It was introduced in f6628c5

I wanted to remove the babel-plugin-add-module-exports dependency as the only file that leverages it is the model.js. The module.exports is needed there because in index.js we need to export Model, { schema } from 'model.js'.

[kdschaffe]

Thanks for the quick response. I just wanted to clarify a little further in case anyone else is confused with how this mixed modules setup works.

One thing I noticed is that removing export default module.exports (es2015) from the model, didn't break anything. What actually gives support for export Model, { schema } from './model' is babel and statge-1 preset.

On the other hand, removing module.exports (commonjs) does cause something to break in index.js but it's the named import import { schema } from './model', not the export.

So what I still want to know for sure is how does module.exports provide a named import.
And, is export default there for any reason other than consistency (using es2015 modules everywhere else)?

[kdschaffe]

I guess a better way to phrase this, would the export in the model be better with something like this:

const model = mongoose.model('Model', schema)
export const schema = model.schema
export default model

[diegohaz]

I like your last snippet. You are right, It looks better. Would you mind to send a PR with this change?

The files are:

• https://github.com/diegohaz/generator-rest/blob/master/generators/api/templates/model.js
• https://github.com/diegohaz/generator-rest/blob/master/generators/app/templates/api/user/model.js
• https://github.com/diegohaz/generator-rest/blob/master/generators/app/templates/api/password-reset/model.js

[kdschaffe]

Sure, no problem. Thanks