Expression transformations for symbolic execution need only be done once #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
efficient-rewrites
branch
from
3685cf6 to
2d0c7ec
Compare
tautschnig
force-pushed
the
efficient-rewrites
branch
from
2d0c7ec to
6b7cb0a
Compare
These should be applied once across all goto functions instead of possibly applying them multiple times to the same source expression during symbolic execution. Signed-off-by: Michael Tautschnig <[email protected]>
tautschnig
force-pushed
the
efficient-rewrites
branch
from
6b7cb0a to
979d120
Compare
Collaborator
|
@kroening I ran into major problems caused by this issue today with a customer. Please can we have this merged to trunk? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and should not modify expressions unnecessarily!