Essential Java dependencies clean up #1935
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
requested review from
chrisr-diffblue,
kroening,
martin-cs,
smowton and
tautschnig
as code owners
peterschrammel
force-pushed
the
java-deps-cleanup
branch
from
6e4df6a to
af671bb
Compare
smowton
reviewed
Mar 13, 2018
Contributor
smowton
left a comment
smowton
left a comment
There was a problem hiding this comment.
Why disable goto-analyzer on Java?
Member
Author
|
@smowton, right, that's too early maybe in this PR because |
peterschrammel
force-pushed
the
java-deps-cleanup
branch
2 times, most recently
from
9fa0719 to
0458a70
Compare
peterschrammel
force-pushed
the
java-deps-cleanup
branch
from
0458a70 to
41b1b79
Compare
peterschrammel
requested review from
cesaro,
mgudemann and
thk123
as code owners
peterschrammel
force-pushed
the
java-deps-cleanup
branch
from
41b1b79 to
88faead
Compare
peterschrammel
force-pushed
the
java-deps-cleanup
branch
from
88faead to
311d195
Compare
thk123
previously approved these changes
Mar 15, 2018
peterschrammel
force-pushed
the
java-deps-cleanup
branch
7 times, most recently
from
90a07e4 to
975d19d
Compare
peterschrammel
changed the title
thk123
dismissed
their stale review
This PR was still on going when I reviewed it, so dismissing out of date review
peterschrammel
force-pushed
the
java-deps-cleanup
branch
from
6ee12f0 to
3ebeb02
Compare
peterschrammel
force-pushed
the
java-deps-cleanup
branch
from
3ebeb02 to
1a70f89
Compare
peterschrammel
force-pushed
the
java-deps-cleanup
branch
from
1a70f89 to
1882558
Compare
peterschrammel
force-pushed
the
java-deps-cleanup
branch
from
1882558 to
3980912
Compare
peterschrammel
force-pushed
the
java-deps-cleanup
branch
from
3980912 to
d146ddf
Compare
Member
Author
|
This PR has been broken down in a series of smaller ones, therefore closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[No review required yet]
Removes all Java specifics from language-independent modules necessary to remove the java_bytecode compilation dependency
Tackles part of #1869