Fix a bug where dynamic objects' dependency across function call is not recognized [depends-on: #2646]

[zhixing-xu]

This pull request includes #2646.
The purpose is to fix the issue raised by the failed test case from #2646. Quoting that test case here:

 #include <assert.h>
 #include <stdlib.h>
 
 static void f(int *x) { *x = 5; }
 static void g(int *x) { assert(*x == 5); }
 
 int main(int argc, char **argv)
 {
   int *x = (int*)malloc(sizeof(int));
   f(x);
   g(x);
   return 0;
 }

CBMC fails to catch the dependency for *x across function calls. Therefore, when running cbmc --full-slice, function f() would get skipped and the assertion fails.

The cause of the bug is: when passing reaching definition between functions, the states of symbols not in symbol table would be erased. The code snippet for that can be found in rd_range_domaint::transform_function_call in reaching_definition.cpp

if((ns.lookup(identifier, sym) || !sym->is_shared()) 
    && !rd.get_is_dirty()(identifier)){  
        export_cache.erase(identifier);
        ...
}

Since *x is a dynamic object, it is not in symbol table. No reaching definition information of it would get passed through function calls.

The fix 968ba27 checks for dynamic objects and do not erase them when going into function call.

One potential problem is: since the dynamic object is given name goto_rw::dynamic-object in #2646. There might be a symbol name confusion if there's a function named goto_rw with variable name start with dynamic-object in the program.

[TGWDB]

Closing due to age (no further comment on PR content), please reopen with rebase on develop if you intent to continue this work.