cfg_dominatorst: introduce a public interface [blocks: 5051] #5045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
chrisr-diffblue,
danpoe,
hannes-steffenhagen-diffblue,
kroening,
martin-cs,
owen-mc-diffblue,
peterschrammel,
pkesseli,
tautschnig and
thk123
as code owners
peterschrammel
approved these changes
Aug 22, 2019
Member
peterschrammel
left a comment
peterschrammel
left a comment
There was a problem hiding this comment.
LGTM modulo documenting the interface.
This was referenced Aug 22, 2019
smowton
force-pushed
the
smowton/cleanup/cfg-dominators-interface
branch
from
68cffe8 to
f7ca671
Compare
This eliminates most use of cfg_dominatorst::cfg, hiding the implementation behind a clean interface.
smowton
force-pushed
the
smowton/cleanup/cfg-dominators-interface
branch
from
f7ca671 to
9620ae6
Compare
peterschrammel
changed the title
allredj
reviewed
Aug 23, 2019
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 9620ae6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/124405489
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates most use of cfg_dominatorst::cfg, hiding the implementation behind a clean interface. No behavioural changes.