Add range-erase to goto_program_template #760
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested changes
Apr 4, 2017
Collaborator
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
I'd strictly reject merging this unless fixing up other instructions is implemented. This function elevates the underlying API (std::list) to goto programs, given the impression that its use is safe and will maintain goto program invariants (and not just std::list invariants).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #691.
Once the goto-programs class has a method to check whether its variants have been maintained, this method should probably check and fix-up the goto program if necessary after the erase.