Enable logging of default flags on tool invocation #8110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NlightNFotis
requested review from
kroening,
martin-cs,
peterschrammel,
tautschnig and
thomasspriggs
as code owners
tautschnig
reviewed
Dec 14, 2023
Comment on lines
+125
to
+147
|
|
||
| if(enabled) | ||
| { | ||
| log.status() << "Running with --standard-checks on: " | ||
| << "bounds-check, pointer-check, pointer-primitive-check, " | ||
| "div-by-zero-check, " | ||
| << "signed-overflow-check, undefined-shift-check and " | ||
| "unwinding-assertions are" | ||
| << "**on** by default for this analysis run.\n" | ||
| << messaget::eom; | ||
| ; | ||
| } | ||
| else | ||
| { // enabled == false | ||
| log.status() << "Running with --no-standard-checks on: " | ||
| << "bounds-check, pointer-check, pointer-primitive-check, " | ||
| "div-by-zero-check, " | ||
| << "signed-overflow-check, undefined-shift-check and " | ||
| "unwinding-assertions are " | ||
| << "**off** by default for this analysis run.\n" | ||
| << messaget::eom; | ||
| ; | ||
| } |
Collaborator
There was a problem hiding this comment.
Could we perhaps do better in the sense that we log the checks that are actually on, rather than just listing the defaults. That is, IMHO --no-standard-checks --pointer-check should produce an output different from the above.
Member
There was a problem hiding this comment.
Yes, the intention was to list the checks that are actually enabled.
Collaborator
|
May I suggest to reduce the verbosity level. There is diminishing return from more output when the attention of a human operator is limited. |
Contributor
Author
|
Closing this as I lack the bandwidth to revive/see this through. If anyone wants to shepherd this in, feel free to re-open or to use the branch as the basis for a separate PR. Thanks for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing a review comment on #8093 and provides a message outlining the level of default checks applied at tool invocation.