aig_nodet constructors
#1488
Merged
aig_nodet constructors
#1488
+29
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
aig_nodet-constructor
branch
3 times, most recently
from
99fb8fa to
94cf1d3
Compare
kroening
force-pushed
the
aig_nodet-constructor
branch
from
94cf1d3 to
9229fa2
Compare
tautschnig
approved these changes
Dec 15, 2025
src/trans-netlist/aig.h
Outdated
Comment on lines
25
to
28
| explicit aig_nodet(literalt::var_not var_no) | ||
| { | ||
| a.set(literalt::unused_var_no(), false); | ||
| b.set(var_no, false); |
Collaborator
There was a problem hiding this comment.
Suggested change
| explicit aig_nodet(literalt::var_not var_no) | |
| { | |
| a.set(literalt::unused_var_no(), false); | |
| b.set(var_no, false); | |
| explicit aig_nodet(literalt::var_not var_no) | |
| : a(literalt::unused_var_no(), false), b(var_no, false) | |
| { |
To avoid unnecessary default-construction of a, b (before .set is called)
Collaborator
Author
There was a problem hiding this comment.
Fixed as proposed
This adds constructors for the two kinds of AIG nodes, preventing uninitialized nodes.
kroening
force-pushed
the
aig_nodet-constructor
branch
from
9229fa2 to
e66ccaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds constructors for the two kinds of AIG nodes, preventing uninitialized nodes.