chore: simplify development installation process#366
Merged
digi-monkey merged 2 commits intodigi-monkey:masterfrom Dec 13, 2023
ahonn:preinstall-script
Merged
chore: simplify development installation process#366digi-monkey merged 2 commits intodigi-monkey:masterfrom ahonn:preinstall-script
digi-monkey merged 2 commits intodigi-monkey:masterfrom
ahonn:preinstall-script
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ahonn
changed the title
Owner
|
do we need to consider the case where rust/wasm-pack is already installed on the host machine? |
Collaborator
Author
Yes, I have made some modifications to check before installing Rust and wasm-pack, so if the user already installed on the host machine, they will not be reinstalled. |
digi-monkey
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current local development installation process requires adding the
–recurse-submodulesparameter when cloning and manually executing theinstall.shscript after cloning. The purpose of this PR is to simplify this process by adding apreinstallscript that automatically pulls submodules and executes scripts before runningyarn (install).