Skip to content

chore: clean _document tag#407

Merged
digi-monkey merged 2 commits intomasterfrom
clean-document-meta-tag
Dec 21, 2023
Merged

chore: clean _document tag#407
digi-monkey merged 2 commits intomasterfrom
clean-document-meta-tag

Conversation

@digi-monkey
Copy link
Copy Markdown
Owner

@digi-monkey digi-monkey commented Dec 20, 2023

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flycat-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 2:47am

@digi-monkey digi-monkey linked an issue Dec 20, 2023 that may be closed by this pull request
clean dead icon/assets on _document.page.tsx #400
Closed
@digi-monkey
Copy link
Copy Markdown
Owner Author

digi-monkey commented Dec 20, 2023

I am confused. do you know why this failed even if it pass the lint? @ahonn

@ahonn
Copy link
Copy Markdown
Collaborator

ahonn commented Dec 20, 2023 •
edited
Loading

I am confused. do you know why this failed even if it pass the lint? @ahonn

This is weird. I can't see the Vercel Development error log, so I don't know why.
Can you send the log to here?

@digi-monkey
Copy link
Copy Markdown
Owner Author

digi-monkey commented Dec 20, 2023 •
edited
Loading

I am confused. do you know why this failed even if it pass the lint? @ahonn

This is weird. I can't see the Vercel Development error log, so I don't know why. Can you send the log to here?

image

it is weird. if I don't edit this part https://github.com/digi-monkey/flycat-web/pull/407/files#diff-73c3d2c5441957b87b6efcbd7cf8acfdc87bd1d3da03b775349f2b8f3a78236cL149 it won't let me pass the pre-commit, but if I did, yarn build won't let me pass either...

@digi-monkey digi-monkey force-pushed the clean-document-meta-tag branch from 17cc34c to f31009a Compare December 20, 2023 13:25
@digi-monkey
Copy link
Copy Markdown
Owner Author

digi-monkey commented Dec 21, 2023 •
edited
Loading

I have to run fmt on .ts/.tsx under /page to bypass this. maybe our codebase is not all formatlized or something wrong with my local setup. cc @ahonn

@digi-monkey digi-monkey merged commit b63f503 into master Dec 21, 2023
@digi-monkey digi-monkey deleted the clean-document-meta-tag branch December 21, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clean dead icon/assets on _document.page.tsx

2 participants

@digi-monkey @ahonn